test_init_bad fails with Python 3.8

[gferon]

Running pytest tests/Settings/TestSettingFunction.py fails on test_init_bad, which I guess means some feature slightly broke with Python 3.8.

======================================================================= test session starts =======================================================================
platform linux -- Python 3.8.2, pytest-4.6.9, py-1.8.0, pluggy-0.13.0
rootdir: /home/gabriel/Development/rpmbuild/BUILD/Uranium-4.6.0, inifile: pytest.ini
collected 35 items                                                                                                                                                

tests/Settings/TestSettingFunction.py .............F.....................                                                                                   [100%]

============================================================================ FAILURES =============================================================================
_____________________________________________________________________ test_init_bad['a_a'[1]] _____________________________________________________________________

setting_function_bad = <UM.Settings.SettingFunction (0x7f761ac14730) ='a_a'[1] >

    def test_init_bad(setting_function_bad):
        assert setting_function_bad is not None
>       assert not setting_function_bad.isValid()
E       AssertionError: assert not True
E        +  where True = <bound method SettingFunction.isValid of <UM.Settings.SettingFunction (0x7f761ac14730) ='a_a'[1] >>()
E        +    where <bound method SettingFunction.isValid of <UM.Settings.SettingFunction (0x7f761ac14730) ='a_a'[1] >> = <UM.Settings.SettingFunction (0x7f761ac14730) ='a_a'[1] >.isValid

tests/Settings/TestSettingFunction.py:72: AssertionError
=============================================================== 1 failed, 34 passed in 0.06 seconds ===============================================================

[nallath]

Could be, but we ship Cura with explicit Python versions for this very reason.

[gferon]

Alright, then I can close this issue. Would you still accept a MR that fixes it for Python 3.8?

[fieldOfView]

Generally, yes, they would, as long as it does not break things for Python < 3.8

[nallath]

What fieldofView said. We've accepted fixes before for versions of python we don't support (because well, it does make it easier once we pull the trigger and upgrade)