Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CircleCI validation #3

Merged
merged 4 commits into from Feb 2, 2021
Merged

CircleCI validation #3

merged 4 commits into from Feb 2, 2021

Conversation

klugier
Copy link
Member

@klugier klugier commented Feb 1, 2021

Added CircleCI json validation. It will be executed after each commit on main branch and PR. It can be improved by writing schema file. Right now it is empty.

@klugier klugier merged commit 3f389d9 into main Feb 2, 2021
@klugier klugier deleted the circleci-project-setup branch February 2, 2021 00:20
@ismail-yilmaz
Copy link
Member

ismail-yilmaz commented Feb 2, 2021

This requires an update to the TheIDE/UppHub source (after that, it works fine).
See: https://github.com/ultimatepp/ultimatepp/blob/85ba75aad8e7ee4f44f8e0b4fc74d568d66c471b/uppsrc/ide/UppHub.cpp#L212

code should be updated to:

Load(0, Nvl(LoadFile(ConfigFile("upphub_root")), "https://raw.githubusercontent.com/ultimatepp/UppHub/main/nests.json"));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants