Bug in drag and drop

[kov-serg]

https://github.com/ultimatepp/ultimatepp/blob/master/uppsrc/Core/Defs.h#L157

typedef uint32             wchar;

https://github.com/ultimatepp/ultimatepp/blob/master/uppsrc/CtrlCore/CtrlClip.cpp#L118

String Unicode__(const WString& w)
{
	return String((const char *)~w, 2 * w.GetLength());
}

wchar is 4 bytes long so string will hold only one first characted.

How to reproduce. Create textedit type some text, select several letters and move it with mouse. It moves only first letter, rest will disappear.

ps:
https://github.com/ultimatepp/ultimatepp/blob/master/uppsrc/plugin/lz4/lib/lz4.c#L1348

static size_t LZ4_stream_t_alignment(void)
{
    struct { char c; LZ4_stream_t t; } t_a;
    return sizeof(t_a) - sizeof(t_a.t);
}

should be replaced with

static size_t LZ4_stream_t_alignment(void)
{
    struct { char c; int* t; } t_a;
    return sizeof(t_a) - sizeof(t_a.t);
}

in order to work with gcc, or it fall's on aligment check nearby an cause segav

[mirek-fidler]

Should be now fixed (by removing Unicode__ functions completely). Thanks for spotting this. pá 8. 4. 2022 v 23:07 odesílatel kov-serg ***@***.***> napsal:

…

https://github.com/ultimatepp/ultimatepp/blob/master/uppsrc/Core/Defs.h#L157 typedef uint32 wchar; https://github.com/ultimatepp/ultimatepp/blob/master/uppsrc/CtrlCore/CtrlClip.cpp#L118 String Unicode__(const WString& w) { return String((const char *)~w, 2 * w.GetLength()); } — Reply to this email directly, view it on GitHub <#69>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AARH235LHWGSNOUJKU2TXF3VECNZ5ANCNFSM5S5UQZEA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[kov-serg]

Did you check result?

From wordpad text inserted without problem using drag and drop. But in reverse direction it paste trash. And from textedit itself paste trash. Problem is in inserting data into clip buffer. It insets it in utf8.

ps: I found. This line

return String(h.begin(), sizeof(char16) * h.GetCount());

should looks like this:

return String((char*)h.begin(), sizeof(char16) * h.GetCount());