Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relative path warnings #83

Closed
Stanzilla opened this issue Jan 21, 2022 · 11 comments · Fixed by #85
Closed

Relative path warnings #83

Stanzilla opened this issue Jan 21, 2022 · 11 comments · Fixed by #85
Assignees
@ultrabug

Comments

@Stanzilla
Copy link

Hey there! Ever since I updated to the latest version (I might have skipped one), I've been getting a lot of relative path warnings again for a lot of files that are actually there.

I can repro this on two systems, mac and Linux, with this repo https://github.com/ManticoreGamesInc/platform-documentation
@ultrabug
Copy link
Owner

Is that still on the development branch that it should be tested?

@ultrabug ultrabug self-assigned this Jan 26, 2022
@Stanzilla
Copy link
Author

Is that still on the development branch that it should be tested?

Yep!

@ultrabug
Copy link
Owner

Yep!

Darn, you've been busy guys, it's a hell to pull :)

ultrabug added a commit that referenced this issue Jan 26, 2022
@ultrabug
on_files: do not skip I18nFiles creation on default_language_only
c14b772 
@Stanzilla reported rightly that when using
default_language_only=true, the build process outputs warning
logs like:

f"A relative path to '{link.url}' is included in the 'nav' "
"configuration, which is not found in the documentation files"

this is due to a premature skip of i18n files population in the
on_files event

closes #83
@ultrabug ultrabug mentioned this issue Jan 26, 2022
Merged
@ultrabug
Copy link
Owner

please review & test #85

thanks!

@Stanzilla
Copy link
Author

please review & test #85

thanks!

That looks good! Only thing I'm not too sure about (which is not new though) is that it displays the missing pages warning twice, even with default_language_only enabled:

INFO     -  The following pages exist in the docs directory, but are not included in the "nav" configuration:
              - icons.md
              - generated/tags.md
INFO     -  The following pages exist in the docs directory, but are not included in the "nav" configuration:
              - icons.md
              - generated/tags.md

ultrabug added a commit that referenced this issue Jan 27, 2022
@ultrabug
on_files: do not skip I18nFiles creation on default_language_only (#85)
df9bf6f 
@Stanzilla reported rightly that when using
default_language_only=true, the build process outputs warning
logs like:

f"A relative path to '{link.url}' is included in the 'nav' "
"configuration, which is not found in the documentation files"

this is due to a premature skip of i18n files population in the
on_files event

closes #83
@ultrabug
Copy link
Owner

Those missing pages info are because we generate a nav for every language, can't do any other way sorry

@Stanzilla
Copy link
Author

Stanzilla commented Jan 27, 2022 •
edited

Alright, thank you! Are you going to do a new release with this change?

@Stanzilla
Copy link
Author

Those missing pages info are because we generate a nav for every language, can't do any other way sorry

After updating to 0.41, I now get the info print 3 times, is that related to language options changes?

@ultrabug
Copy link
Owner

ultrabug commented Feb 7, 2022

After updating to 0.41, I now get the info print 3 times, is that related to language options changes?

Yes, and I see that I missed skipping the on_nav for languages with build: False so that's my bad, thanks for the hint.

@ultrabug
Copy link
Owner

ultrabug commented Feb 7, 2022

b1523f5

@Stanzilla
Copy link
Author

hah, glad I could help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ultrabug ultrabug

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

on_files: do not skip I18nFiles creation on default_language_only ultrabug/mkdocs-static-i18n
2 participants
@Stanzilla @ultrabug