-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix of "OSError: [WinError 6] The handle is invalid" #1339
Open
enesgorkemgenc
wants to merge
1
commit into
ultrafunkamsterdam:master
Choose a base branch
from
enesgorkemgenc:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This error seems to be a problem for a lot of users of the package. Adding a try-except block is solving the issue for them while keeping it functional for the others as well. Source: ultrafunkamsterdam#955
Open
This fix works for me. Thanks! |
Works for me as well. |
It works for me. When will this be merged? |
Yeah this fix works well for me on an AWS EC2 env. |
LaurentOngaro
pushed a commit
to LaurentOngaro/F_undetected-chromedriver
that referenced
this pull request
Apr 5, 2024
lol I got this error too on the same line - nice to see someone fixed it in a PR |
ooojustin
reviewed
Jun 23, 2024
Comment on lines
+788
to
+789
except OSError: | ||
pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be a bit more specific about what this is handling:
Suggested change
except OSError: | |
pass | |
except OSError as ex: | |
if getattr(ex, "winerror", None) == 6: | |
pass | |
else: | |
raise ex |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error seems to be a problem for a lot of users of the package. Adding a try-except block is solving the issue for them while keeping it functional for the others as well.
Source: #955