Fix dealing with None types

ultrajson · Oct 30, 2020 · 7687b3d · 7687b3d
1 parent ed4cfe5
commit 7687b3d
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 5 deletions.
diff --git a/python/objToJSON.c b/python/objToJSON.c
@@ -258,7 +258,9 @@ static int Dict_iterNext(JSOBJ obj, JSONTypeContext *tc)
   {
     if (UNLIKELY(GET_TC(tc)->itemName == Py_None))
     {
-      GET_TC(tc)->itemName = PyUnicode_FromString("null");
+      itemNameTmp = PyUnicode_FromString("null");
+      GET_TC(tc)->itemName = PyUnicode_AsUTF8String(itemNameTmp);
+      Py_DECREF(Py_None);
       return 1;
     }
 
@@ -537,17 +539,17 @@ static void Object_beginTypeContext (JSOBJ _obj, JSONTypeContext *tc, JSONObject
     return;
   }
   else
-  if (PyFloat_Check(obj) || object_is_decimal_type(obj))
+  if (obj == Py_None)
   {
     PRINTMARK();
-    pc->PyTypeToJSON = PyFloatToDOUBLE; tc->type = JT_DOUBLE;
+    tc->type = JT_NULL;
     return;
   }
   else
-  if (obj == Py_None)
+  if (PyFloat_Check(obj) || object_is_decimal_type(obj))
   {
     PRINTMARK();
-    tc->type = JT_NULL;
+    pc->PyTypeToJSON = PyFloatToDOUBLE; tc->type = JT_DOUBLE;
     return;
   }
 

diff --git a/tests/test_ujson.py b/tests/test_ujson.py
@@ -806,6 +806,11 @@ def test_reject_bytes_false():
     assert ujson.dumps(data, reject_bytes=False) == '{"a":"b"}'
 
 
+def test_encode_none_key():
+    data = {None: None}
+    assert ujson.dumps(data) == '{"null":null}'
+
+
 """
 def test_decode_numeric_int_frc_overflow():
 input = "X.Y"