Add manylinux to CI wheels build

[bwoodsend]

Amends PR #405 to include manylinux in the same workflow action.

The legwork is being done by a new script scripts/build-manylinux-wheels.sh which runs inside the docker and does all the building. The results are here. I tried gluing in the original python script you have before but I didn't get anywhere.

I threw in a 32bit manylinux docker image as well - more just out of curiosity to see if it works. It's up to you if you want to keep it.

Currently it does all versions of Python and both dockers (8 builds in total) all in one build so it's a bit slow. If this bothers you I'll split it up a bit.

We'll probably want to rename the files and actions. I've left that so you can choose the names.

[hugovk]

Thanks! These are mostly little nits.

[bwoodsend]

Also try changing the permissions on the file in Git:

chmod 777 scripts/build-manylinux-wheels.sh
git add scripts/build-manylinux-wheels.sh
git commit -m "Update permissions"
git push

Unfortunately that didn't do it. https://github.com/bwoodsend/ultrajson/runs/656760101
It still came out with 644 when calling git ls-files --stage scripts/build-manylinux-wheels.sh. Had to use git update-index --chmod=+x scripts/build-manylinux-wheels.sh.

[bwoodsend]

There we go - think that's all the nits knitted out.

[bwoodsend]

Here's the latest build in case you can't already see it.

[hugovk]

https://pypi.org/project/ujson/2.0.3/#files shows one *-manylinux1_x86_64.whl per Python version.

The artifacts at https://github.com/bwoodsend/ultrajson/runs/656897993?check_suite_focus=true have 3 wheels per Python version:

ujson-2.0.4.dev80-cp35-cp35m-linux_x86_64.manylinux1_i686.whl
ujson-2.0.4.dev80-cp35-cp35m-manylinux1_i686.whl
ujson-2.0.4.dev80-cp35-cp35m-manylinux1_x86_64.whl
ujson-2.0.4.dev80-cp36-cp36m-manylinux1_i686.linux_x86_64.whl
ujson-2.0.4.dev80-cp36-cp36m-manylinux1_i686.whl
ujson-2.0.4.dev80-cp36-cp36m-manylinux1_x86_64.whl
ujson-2.0.4.dev80-cp37-cp37m-manylinux1_i686.linux_x86_64.whl
ujson-2.0.4.dev80-cp37-cp37m-manylinux1_i686.whl
ujson-2.0.4.dev80-cp37-cp37m-manylinux1_x86_64.whl
ujson-2.0.4.dev80-cp38-cp38-linux_x86_64.manylinux1_i686.whl
ujson-2.0.4.dev80-cp38-cp38-manylinux1_i686.whl
ujson-2.0.4.dev80-cp38-cp38-manylinux1_x86_64.whl

Do you know why this is and what the difference is?

[bwoodsend]

OK so the *-manylinux1_x86_64.whl wheels are built in the 64bit docker image manylinux1_x86_64.
The *-manylinux1_i686.whl ones are from the 32bit manylinux1_i686 image.

The *linux_x86_64.manylinux1_i686.whl ones shouldn't be there. That's a bug. It looks like the old 64bit wheels left in the temp-wheels folder are being audited in the 32bit docker. The fix for this would be to clean the temp-wheels folder beforehand which I'll do. I do find strange though that auditwheel was happy to pass 64bit wheels as 32bit. Testing those on 32bit docker with the rather meaty command:

docker run  -e PLAT=manylinux1_i686  -v `pwd`:/io  quay.io/pypa/manylinux1_i686 /bin/bash -c "/opt/python/cp37-cp37m/bin/python -m pip install /io/dist/ujson-2.0.4.dev80-cp37-cp37m-linux_x86_64.manylinux1_i686.whl; /opt/python/cp37-cp37m/bin/python -m pip install pytest; cd /io/ && /opt/python/cp37-cp37m/bin/python -m pytest"

shows that they don't work. They need to go.

[bwoodsend]

Think that's it sorted now.
https://github.com/bwoodsend/ultrajson/runs/657661961?check_suite_focus=true

[hugovk]

Alternatively, rm -rf /io/temp-wheels before the mkdir. Either is fine.

[hugovk]

Do you know why the macOS/3.8 job was cancelled here?

https://github.com/bwoodsend/ultrajson/runs/657661946?check_suite_focus=true

---

Let's add this at the top, it means if one job does fail for some reason, it won't auto-cancel the other jobs:

ultrajson/.github/workflows/test.yml

Lines 8 to 9 in 81feb55

	strategy:
	fail-fast: false

[bwoodsend]

Do you know why the macOS/3.8 job was cancelled here?

No I don't. That's weird. I pressed the rerun button. And they all finished this time. Could I have just exceeded some CI minutes quota?

[hugovk]

There should be plenty of quota for open source. Anyway, looking good now, thanks again!

[hugovk]

👍 And there they are at TestPyPI https://test.pypi.org/project/ujson/2.0.4.dev96/#files

[bwoodsend]

manylinux has moved on a bit since this. Now an AUDITWHEEL_PLAT environment variable is baked into each docker image and auditwheel checks for this variable automatically so the manual -e PLAT=manylinux1_x86_64 and --plat=$PLAT can go. Would you be interested in a clean up PR?

[hugovk]

Sounds good, yes please!