-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add manylinux to CI wheels build #406
Merged
Merged
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
69c298e
Add manylinux build.
bwoodsend 0f6afcc
More to trigger action build than to make a change
bwoodsend 06d4d80
Ubuntu appears to be using an old python
bwoodsend a05a3a6
Think this was the issue
bwoodsend ef39547
ujson version not being passed on
bwoodsend 4bc9f1b
Try this to get version instead
bwoodsend 6eaa240
Add default of for manylinux script. Use that in CI script.
bwoodsend 3e5937c
Add and switch to new docker build script.
bwoodsend f09dc66
Update deploy-macos-windows.yml
bwoodsend 4e3f8c9
Update deploy-macos-windows.yml
bwoodsend e0a6fcc
Update deploy-macos-windows.yml
bwoodsend e9b2ec1
Update deploy-macos-windows.yml
bwoodsend bb0a528
Update deploy-macos-windows.yml
bwoodsend a50a148
Update build-wheels.sh
bwoodsend 5fc87f9
Clear up a bit.
bwoodsend 4798669
Knew I'd forget to update the name somewhere
bwoodsend 68cd7ca
Change this back to what it was before I fiddled with it.
bwoodsend 430538a
Update .github/workflows/deploy-macos-windows.yml
bwoodsend 96a76ff
Update .github/workflows/deploy-macos-windows.yml
bwoodsend e5d225a
Update .github/workflows/deploy-macos-windows.yml
bwoodsend ab608ba
Update .github/workflows/deploy-macos-windows.yml
bwoodsend 5118d46
Update .github/workflows/deploy-macos-windows.yml
bwoodsend 6cfcb29
Update scripts/build-manylinux-wheels.sh
bwoodsend 7b57fb7
Update scripts/build-manylinux-wheels.sh
bwoodsend bb0f8ee
Update scripts/build-manylinux-wheels.sh
bwoodsend a6be591
Update scripts/build-manylinux-wheels.sh
bwoodsend 68c6271
Fix line endings back to LF
bwoodsend 4a411e0
Rename wheel building yml to appropriate name.
bwoodsend cefb530
Update scripts/build-manylinux-wheels.sh
bwoodsend 3ae3849
Update scripts/build-manylinux-wheels.sh
bwoodsend be21532
Try without setting permissions in the workflow.
bwoodsend 971839b
change file permissions and make build-manylinux-wheels.sh executable
bwoodsend ac0a8b4
Remove sudo in comment.
bwoodsend 5248177
Add Cleanup of temp-wheels before populating with new wheels. A few w…
bwoodsend d267ec6
`rm` doesn't work with wildcards in linux1
bwoodsend 7d3a5eb
Linux1 also doesn't handle zero length loops properly
bwoodsend 4baa204
Disable fail-fast
bwoodsend File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
#!/bin/bash | ||
set -e -x | ||
|
||
# This is to be run by Docker inside a Docker image. | ||
# You can test it locally on a Linux machine by installing docker and running from this repo's root: | ||
# $ docker run -e PLAT=manylinux1_x86_64 -v `pwd`:/io quay.io/pypa/manylinux1_x86_64 /io/scripts/build-manylinux-wheels.sh | ||
|
||
# The -e just defines an evironment variable PLAT=[docker name] inside the docker - auditwheel can't detect the docker name automatically. | ||
# The -v gives a directory alias for passing files in and out of the docker. (/io is arbitrary). E.g the setup.py script can be accessed in the docker via /io/setup.py | ||
# quay.io/pypa/manylinux1_x86_64 is the full docker image name. Docker downloads it automatically. | ||
# The last argument is a shell command that the Docker will execute. Filenames must be from the Docker's perspective. | ||
|
||
# Wheels are initially generated as you would usually, but put in a temp directory temp-wheels. | ||
# The pip-cache is optional but can speed up local builds having a real permanent pip-cache dir. | ||
mkdir -p /io/pip-cache | ||
mkdir -p /io/temp-wheels | ||
|
||
# Clean out any old existing wheels. | ||
find /io/temp-wheels/ -type f -delete | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Alternatively, |
||
|
||
for PYBIN in /opt/python/cp3[5678]*/bin; do | ||
"${PYBIN}/pip" install -q -U setuptools wheel pytest --cache-dir /io/pip-cache | ||
(cd /io/ && "${PYBIN}/python" -m pip install .) | ||
(cd /io/ && "${PYBIN}/python" -m pytest) | ||
(cd /io/ && "${PYBIN}/python" setup.py -q bdist_wheel -d /io/temp-wheels) | ||
done | ||
|
||
"$PYBIN/pip" install -q auditwheel | ||
|
||
# Wheels aren't considered manylinux unless they have been through | ||
# auditwheel. Audited wheels go in /io/dist/. | ||
mkdir -p /io/dist/ | ||
|
||
for whl in /io/temp-wheels/*.whl; do | ||
auditwheel repair "$whl" --plat $PLAT -w /io/dist/ | ||
done | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.