-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a default keyword argument to dumps #470
Conversation
6f80bf2
to
ff9d82e
Compare
9e7e8c2
to
4bd5ae3
Compare
Codecov Report
@@ Coverage Diff @@
## main #470 +/- ##
==========================================
+ Coverage 88.65% 88.94% +0.29%
==========================================
Files 6 6
Lines 1631 1683 +52
==========================================
+ Hits 1446 1497 +51
- Misses 185 186 +1
Continue to review full report at Codecov.
|
dump and dumps functions in python json stdlib have a default keyword argument. It's useful for serializing complex objects. Supporting this argument will improve compatibility and flexibility of ujson.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
dump
anddumps
functions in pythonjson
stdlib have adefault
keyword argument.It's useful for serializing complex objects. So I think supporting this argument will improve
compatibility and flexibility of
ujson
.https://docs.python.org/3/library/json.html
This should resolve #436 .