new reject_bytes option to raise on bytes

[elelay]

raise TypeError when encountering bytes in ujson.dumps() to prevent
unexpected Unicode exceptions in production.
Fixes #264

[Jahaja]

Hi, thanks for the PR. This should probably be the new default as it aligns with the standard json modules behaviour.

[elelay]

Great! I'm looking forward to that.

[hugovk]

@elelay Please could you resolve the merge conflicts?

And also have it with reject_bytes = True by default, or perhaps flip it to allow_bytes = False by default?

No need to support Python 2.7 any more, so PyString_AS_STRING -> PyBytes_AS_STRING.

The project is now using pytest, so perhaps something like:

def test_allow_bytes_default():
    data = {"a": b"b"}
    with pytest.raises(TypeError):
        ujson.dumps(data)


def test_allow_bytes_false():
    data = {"a": b"b"}
    with pytest.raises(TypeError):
        ujson.dumps(data, allow_bytes=False)


def test_allow_bytes_true():
    data = {"a": b"b"}
    assert ujson.dumps(data, allow_bytes=True) == '{"a":"b"}'

Sorry this has taken a while! Because this is a breaking change, it would be good to get this in the 3.0 release due out in the next week or so, if possible.

Thank you!

[elelay]

OK. I'll do this on Friday.

[elelay]

inverting the logic will break those tests:

• test_encode_unicode_4_bytes_utf8_fail
• test_encode_big_escape

[hugovk]

Thank you!