New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for Python 3.7 #595
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #595 +/- ##
=======================================
Coverage 91.66% 91.66%
=======================================
Files 6 6
Lines 1944 1944
=======================================
Hits 1782 1782
Misses 162 162 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I agree with the poll. Semantic versioning exists pretty much exlusivley so that people can write |
I've flipped the labels so the automation will take care of the next version (minor instead of major). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with both merging now and waiting until EOL. As you say, close enough, and even if something urgent comes up that we will fix in the next couple weeks, people should still upgrade to 3.8+ anyway.
And agreed that no major bump is necessary.
Python 3.7 is EOL this month:
Let's drop it, it'll save us 14 wheels (and we're adding more for 3.12 in #594 :)
I don't mind if wait until 2023-06-27, but we're probably close enough.