Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.7 #595

Merged
merged 2 commits into from Jun 4, 2023
Merged

Drop support for Python 3.7 #595

merged 2 commits into from Jun 4, 2023

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Jun 3, 2023

Python 3.7 is EOL this month:

image

Let's drop it, it'll save us 14 wheels (and we're adding more for 3.12 in #594 :)

I don't mind if wait until 2023-06-27, but we're probably close enough.

@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2023

Codecov Report

Merging #595 (92af18b) into main (e1dfadc) will not change coverage.
The diff coverage is n/a.

❗ Current head 92af18b differs from pull request most recent head b042a39. Consider uploading reports for the commit b042a39 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #595   +/-   ##
=======================================
  Coverage   91.66%   91.66%           
=======================================
  Files           6        6           
  Lines        1944     1944           
=======================================
  Hits         1782     1782           
  Misses        162      162           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bwoodsend bwoodsend added the changelog: Removed For now removed features label Jun 3, 2023
@hugovk
Copy link
Member Author

hugovk commented Jun 3, 2023

Does dropping a Python warrant a major or minor bump?

I used to do major, but python_requires = >=3.8 ensures the new release only installs for the right group, and I'm now leaning towards a minor, but either is fine with me.

(If we had deprecations to drop, I'd do those at the same time and do major, but we don't.)

A recent poll on the topic favours minor:

image

https://hachyderm.io/@nedbat/110412912217669532

@bwoodsend
Copy link
Collaborator

I agree with the poll. Semantic versioning exists pretty much exlusivley so that people can write package >= 2.x.y; < 3.0.0 and receive automatic improvements without automatic breakages. It's not needed to avoid new versions of packages being installed with too old Python environments because there's a separate mechanism for it.

@hugovk hugovk added changelog: Changed For changes in existing functionality and removed changelog: Removed For now removed features labels Jun 3, 2023
@hugovk
Copy link
Member Author

hugovk commented Jun 3, 2023

I've flipped the labels so the automation will take care of the next version (minor instead of major).

Copy link
Collaborator

@JustAnotherArchivist JustAnotherArchivist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with both merging now and waiting until EOL. As you say, close enough, and even if something urgent comes up that we will fix in the next couple weeks, people should still upgrade to 3.8+ anyway.

And agreed that no major bump is necessary.

@hugovk hugovk enabled auto-merge June 4, 2023 20:22
@hugovk hugovk merged commit b527914 into ultrajson:main Jun 4, 2023
33 checks passed
@hugovk hugovk deleted the rm-3.7 branch June 5, 2023 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: Changed For changes in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants