Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore(bug) updates for better upm package dependency flow #1173

Closed
wants to merge 8 commits into from
Closed

Chore(bug) updates for better upm package dependency flow #1173

wants to merge 8 commits into from

Conversation

StephenHodgson
Copy link
Contributor

@StephenHodgson StephenHodgson commented Dec 10, 2021 •
edited
Loading

  • Fixed compiler warnings in new upm package
    image
  • Fixed unit tests so they don't show up in downstream dependencies unless explicitly referenced

@StephenHodgson
fixed compiler warnings
6125d4b
@StephenHodgson
fixed unit tests following into dependencies
d04cac6 
fixed a few more compiler errors
fixed project unable to open without assets folder
@StephenHodgson StephenHodgson changed the title fixed compiler warnings Misc fixes for better upm package dependency flow Dec 10, 2021
@Craig-J
Copy link
Contributor

Craig-J commented Dec 10, 2021

Hey Stephen, thanks for the contribution.
We deliberately moved away from the repository being a unity project itself, the new repository layout is not intended to be opened as a unity project from the root. Sorry for the confusion! I'd suggest the contributor workflow described in the readme.

@StephenHodgson
Copy link
Contributor Author

@Craig-J reverted those specific changes then. Thanks for the clarification.

@StephenHodgson
Copy link
Contributor Author

@Craig-J This PR is ready for review.

@StephenHodgson StephenHodgson changed the title Misc fixes for better upm package dependency flow Chore(bug) updates for better upm package dependency flow Dec 10, 2021
@StephenHodgson
Copy link
Contributor Author

Any update on this?

@MaxPalmer-UH
Copy link
Contributor

Looks good to me. Thanks @StephenHodgson, just waiting on Craig who is currently off sick.

Craig-J
Craig-J suggested changes Dec 20, 2021
View reviewed changes
Copy link
Contributor

@Craig-J Craig-J left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New function in LeapCSharp makes it a minor release rather than hotfix. We'll probably change version to 5.1.0 as there's other changes going into next release but I'm happy for this not to block the MR.

We don't have an explicit process for merging from GitHub right now. We will pull down to our GitLab instance and merge it to develop if CI passes.

Packages/Tracking Preview/UI Input/Runtime/Scripts/PointerElement.cs Show resolved Hide resolved
Packages/Tracking Preview/package.json Show resolved Hide resolved
@StephenHodgson StephenHodgson deleted the fix/warnings branch February 27, 2022 08:23
@StephenHodgson StephenHodgson mentioned this pull request Apr 6, 2022
Closed
DevOps-UH pushed a commit that referenced this pull request Apr 22, 2022
@MaxPalmer-UH
Merge branch 'fix/#1173' into 'develop'
10d62c6 
Fix/#1173

Closes UNITY-606

See merge request xr/integrations/unityplugin!212
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Craig-J Craig-J Awaiting requested review from Craig-J

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@StephenHodgson @Craig-J @MaxPalmer-UH