-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore(bug) updates for better upm package dependency flow #1173
Conversation
StephenHodgson
commented
Dec 10, 2021
•
edited
edited
- Fixed compiler warnings in new upm package
- Fixed unit tests so they don't show up in downstream dependencies unless explicitly referenced
fixed a few more compiler errors fixed project unable to open without assets folder
Hey Stephen, thanks for the contribution. |
@Craig-J reverted those specific changes then. Thanks for the clarification. |
@Craig-J This PR is ready for review. |
Any update on this? |
Looks good to me. Thanks @StephenHodgson, just waiting on Craig who is currently off sick. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New function in LeapCSharp makes it a minor release rather than hotfix. We'll probably change version to 5.1.0 as there's other changes going into next release but I'm happy for this not to block the MR.
We don't have an explicit process for merging from GitHub right now. We will pull down to our GitLab instance and merge it to develop if CI passes.
Fix/#1173 Closes UNITY-606 See merge request xr/integrations/unityplugin!212