Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/unity 1206 address obsolete find objects of type #1494

Merged

Conversation

MattGrayUL
Copy link
Contributor

@MattGrayUL MattGrayUL commented Aug 16, 2023

Summary

Replaces the now-obsolete use of find objects of type with newer implementations

Contributor Tasks

  • Create or edit test cases here
  • Add a CHANGELOG entry for this change.
  • Ensure documentation requirements are met e.g., public API is commented.
  • Consider any licensing/other legal implications for this MR e.g. notices required by any new libraries.
  • Add any relevant labels such as breaking to this MR.

Reviewer Tasks

Add any instructions or tasks for the reviewer such as specific test considerations before this can be merged.

Use emojis in review threads to communicate intent and help contributors.

  • Run all tests associated with the ticket.
  • Code reviewed.
  • Non-code assets e.g. Unity assets/scenes reviewed.
  • Documentation has been reviewed.
  • Approve with a comment of any additional tests run or any observations.

Closes JIRA Issue

Closes UNITY-1206

Copy link
Contributor

@BryceNewell-UL BryceNewell-UL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot test every change but have tested several and all seem good.

…bjectsOfType

# Conflicts:
#	Packages/Tracking/CHANGELOG.md
@BryceNewell-UL BryceNewell-UL merged commit b62bd72 into develop Sep 14, 2023
1 check passed
@BryceNewell-UL BryceNewell-UL deleted the feature/UNITY-1206-Address-obsolete-FindObjectsOfType branch September 14, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants