Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/unity 1451 shader unification #1612

Merged

Conversation

MattGrayUL
Copy link
Contributor

@MattGrayUL MattGrayUL commented May 13, 2024

Contributor Tasks

  • Create or edit test cases here
  • Add a CHANGELOG entry for this change.
  • Ensure documentation requirements are met e.g., public API is commented.
  • Consider any licensing/other legal implications for this MR e.g. notices required by any new libraries.

Test Cycle

Link to the test cycle here.

Reviewer Tasks

  • Code reviewed.
  • Non-code assets e.g. Unity assets/scenes reviewed.
  • All tests must be ran and cover all scenarios (If not, add new tests to the cycle and run them).
  • Documentation has been reviewed.
  • Approve with a comment of any additional tests run or any observations.

Related JIRA Issues

Closes UNITY-1451 & UNITY-936

@MattGrayUL MattGrayUL marked this pull request as ready for review May 29, 2024 14:57
@MattGrayUL MattGrayUL merged commit 89dced7 into feature/PhysicalHandsParity Jun 3, 2024
@MattGrayUL MattGrayUL deleted the feature/UNITY-1451-Shader_unification branch June 3, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants