feature/core-bluetooth #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| if let char = characteristics?.first(where: { $0.uuid == CoreBluetoothTransport.receiveCharacteristicUUID }) { | ||
| peripherals[id] = (peripheral, char) | ||
| peripherals[id]?.peripheral.setNotifyValue(true, for: char) | ||
| peers.append(Peer(id: id, services: [UBID]())) // @TODO SERVICES |
There was a problem hiding this comment.
TODOs should be resolved (SERVICES).
| if let char = characteristics?.first(where: { $0.uuid == CoreBluetoothTransport.receiveCharacteristicUUID }) { | ||
| peripherals[id] = (peripheral, char) | ||
| peripherals[id]?.peripheral.setNotifyValue(true, for: char) | ||
| peers.append(Peer(id: id, services: [UBID]())) // @todo we may need to do some handshake to obtain services from a peer. |
There was a problem hiding this comment.
Line should be 120 characters or less: currently 132 characters
GregTheGreek
requested changes
Sep 10, 2019
| if sends > 0 { | ||
| return | ||
| } | ||
| } | ||
| } | ||
|
|
||
| _ = send(message, transport: transport, peers: peers) | ||
| _ = send(message, data: data, transport: transport, peers: peers) |
Closed
decanus
previously approved these changes
Sep 10, 2019
|
Code Climate has analyzed commit 6070337 and detected 0 issues on this pull request. View more on Code Climate. |
decanus
approved these changes
Sep 11, 2019
GregTheGreek
approved these changes
Sep 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bi-directional message sending is working. Need to write more tests and test for multiple devices.
Relevant issues:
closes #25
closes #26