Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve PNNX assets check robustness #10089

Merged
merged 1 commit into from Apr 16, 2024
Merged

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Apr 16, 2024

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Improved reliability in fetching PNNX assets for different operating systems.

πŸ“Š Key Changes

  • Removed the retry option from the get_github_assets function call.
  • Added an assertion to ensure a URL is found for the PNNX repo assets.
  • Established a fallback URL with a specific version if the asset retrieval fails.

🎯 Purpose & Impact

  • Enhance Stability: By removing the retry option and adding an assertion, the process is simplified, aiming at reducing potential errors during asset fetching. πŸ› οΈ
  • Better Error Handling: In cases where the PNNX assets cannot be found, a default fallback URL ensures that the operation can still proceed, albeit with a specific version. This minimizes disruptions to the user experience. πŸ”„
  • User Confidence: The changes help ensure that users have access to the necessary assets regardless of their operating system, which is crucial for seamless functionality across different environments. πŸŒβœ…

@glenn-jocher glenn-jocher merged commit 03badaf into main Apr 16, 2024
11 checks passed
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch April 16, 2024 23:19
hmurari pushed a commit to hmurari/ultralytics that referenced this pull request Apr 17, 2024
dimidagd pushed a commit to dimidagd/ultralytics_dotav2 that referenced this pull request Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant