-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix det.summary()
bug for ultralytics>=8.2.10
#13024
Conversation
… object inside and outside region
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13024 +/- ##
===========================================
- Coverage 70.96% 37.44% -33.53%
===========================================
Files 123 123
Lines 15566 15566
===========================================
- Hits 11047 5829 -5218
- Misses 4519 9737 +5218
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
-data = self.boxes or self.obb
-is_obb = self.obb is not None
+is_obb = self.obb is not None
+data = self.obb if is_obb else self.boxes @hdnh2006 Thanks for the PR! how about we settle |
Absolutely! your way to manage Your suggested changes have been done, please check once the CI pipeline finishes @Laughing-q . |
@hdnh2006 @Laughing-q thank you guys, PR merged! |
Co-authored-by: UltralyticsAssistant <web@ultralytics.com> Co-authored-by: Glenn Jocher <glenn.jocher@ultralytics.com> Co-authored-by: hdnh2006 <henry.matucv@gmail.com>
Hello!
I feel embarrassed to upload this PR 🤣🤣🤣. I literally changed one line of code but here you have the PR to fix this issue: #13023
When
len(self.bboxes)==0
the value of post processing data is set to None here:ultralytics/ultralytics/engine/results.py
Line 405 in f0b7c51
So I just added
[]
in the end and that's all:https://github.com/hdnh2006/ultralytics/blob/35fb8f72c50a7e803f3cf083304f0ac6a9d591ab/ultralytics/engine/results.py#L405
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Improved data handling in result summaries for better clarity and efficiency.
📊 Key Changes
boxes
) and oriented bounding boxes (obb
) is now more straightforward with a cleaner, more readable conditional assignment.boxes
orobb
) now explicitly checks for the presence ofobb
first, before defaulting toboxes
, enhancing the code's logic flow.🎯 Purpose & Impact
obb
vs.boxes
), the code might execute slightly faster under certain conditions, potentially improving overall performance.