-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rt info for OpenVINO ModelAPI #2891
Add rt info for OpenVINO ModelAPI #2891
Conversation
@AlexKoff88 @Wovchena I've updated this PR in f3b6624 to omit classification models from the letterbox input type, and cleaned up the class names. Please take a look at my changes. If everything looks good I'll go ahead and merge! |
@glenn-jocher, thank you. openvinotoolkit/model_api#71 isn't ready yet. So there's no rush to merge ultralytics PR unless there is a specific date by which this PR needs to be merged. Plus I didn't figure out how to extract confidence threshold from |
labels = []
for i in range(len(self.model.names)):
labels.append(self.model.names[i].replace(' ', '_'))
ov_model.set_rt_info(labels, ['model_info', 'labels']) Was written that way on purpose. That way ensures that |
for more information, see https://pre-commit.ci
Got it! The class ![]() In any case I've updated this to force sorted order again in 9242c7f |
There's still concern about
But if you think it's also fine, I'm ok with your appriach. |
@Wovchena thank you for your feedback. Regarding the concern about |
@Wovchena ok I've tested the current implementation and confirm that it will always sort a dict to a list by the dict keys, so no need to worry there. I think this is all good then, I'll go ahead and merge! |
@Wovchena actually, are you waiting on any changes from your side before I merge? I remember you mentioned a confidence threshold parameter you'd like to introduce. |
You can merge. This PR doesn't invalidate anything. I can bring missing changes later. |
@Wovchena PR merged! |
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Glenn Jocher <glenn.jocher@ultralytics.com> Co-authored-by: Ayush Chaurasia <ayush.chaurarsia@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Glenn Jocher <glenn.jocher@ultralytics.com> Co-authored-by: Ayush Chaurasia <ayush.chaurarsia@gmail.com>
Refer to openvinotoolkit/model_api#71
π€ Generated by Copilot at 97a2323
Summary
πππ§
Added runtime information to OpenVINO model exported from
yolo/engine/exporter.py
. This enables the OpenVINO Inference Engine to use the model and process the results.Walkthrough
π οΈ PR Summary
Made with β€οΈ by Ultralytics Actions
π Summary
Enhancements to OpenVINO model export with additional runtime information.
π Key Changes
π― Purpose & Impact