Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OBB: update metrics #7593

Merged
merged 1 commit into from Jan 15, 2024
Merged

OBB: update metrics #7593

merged 1 commit into from Jan 15, 2024

Conversation

Laughing-q
Copy link
Member

@Laughing-q Laughing-q commented Jan 15, 2024

Thank you πŸ™ for your contribution to Ultralytics πŸš€! Your effort in enhancing our repositories is greatly appreciated. To streamline the process and assist us in integrating your Pull Request (PR) effectively, please follow these steps:

  1. Check for Existing Contributions: Before submitting, kindly explore existing PRs to ensure your contribution is unique and complementary.

  2. Link Related Issues: If your PR addresses an open issue, please link it in your submission. This helps us better understand the context and impact of your contribution.

  3. Elaborate Your Changes: Clearly articulate the purpose of your PR. Whether it's a bug fix or a new feature, a detailed description aids in a smoother integration process.

  4. Ultralytics Contributor License Agreement (CLA): To uphold the quality and integrity of our project, we require all contributors to sign the CLA. Please confirm your agreement by commenting below:

    I have read the CLA Document and I hereby sign the CLA

For more detailed guidance and best practices on contributing, refer to our βœ… Contributing Guide. Your adherence to these guidelines ensures a faster and more effective review process.

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Improved accuracy for YOLOv8 OBB models and updated dataset recommendations.

πŸ“Š Key Changes

  • Increased mAP (mean Average Precision) results for YOLOv8n-obb and YOLOv8s-obb models.
  • Updated the default dataset in the example code for OBB validators to dota8.yaml.
  • Adjusted an error message for clarity when incorrectly training an OBB model on a detection dataset.

🎯 Purpose & Impact

  • Enhanced performance: The improved mAP values indicate that the models perform better in object detection tasks, which is a significant benefit for users needing high accuracy.
  • Clearer guidance: The use of a more appropriate default dataset (dota8.yaml) in code examples helps prevent user errors when training models.
  • The updated error message provides clearer instructions and helps users troubleshoot and correct their training setup more easily.

Copy link

sentry-io bot commented Jan 15, 2024

πŸ” Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

πŸ“„ File: ultralytics/utils/loss.py

Function Unhandled Issue
__call__ RuntimeError: Sizes of tensors must match except in dimension 1. Expected size 1127 but got size 576 for tensor... ...
Event Count: 13
__call__ RuntimeError: Expected all tensors to be on the same device, but found at least two devices, cpu and cuda:0! (w... ...
Event Count: 5
__call__ TypeError: ERROR ❌ segment dataset incorrectly formatted or not a segment dataset. ...
Event Count: 5
__call__ TypeError: cross_entropy_loss(): argument 'input' (position 1) must be Tensor, not list ...
Event Count: 5
__call__ TypeError: ERROR ❌ OBB dataset incorrectly formatted or not a OBB dataset. ultralyt...
Event Count: 5

Did you find this useful? React with a πŸ‘ or πŸ‘Ž

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (cf50bd9) 77.23% compared to head (927586a) 74.48%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7593      +/-   ##
==========================================
- Coverage   77.23%   74.48%   -2.76%     
==========================================
  Files         117      117              
  Lines       14327    14327              
==========================================
- Hits        11065    10671     -394     
- Misses       3262     3656     +394     
Flag Coverage Ξ”
Benchmarks ?
GPU 39.60% <ΓΈ> (ΓΈ)
Tests 72.37% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@UltralyticsAssistant UltralyticsAssistant added bug Something isn't working APP Ultralytics HUB App issues labels Jan 15, 2024
@glenn-jocher glenn-jocher removed bug Something isn't working APP Ultralytics HUB App issues labels Jan 15, 2024
@glenn-jocher glenn-jocher merged commit b093dce into main Jan 15, 2024
12 checks passed
@glenn-jocher glenn-jocher deleted the obb_metrics branch January 15, 2024 20:03
@glenn-jocher
Copy link
Member

@Laughing-q thanks, looks good!

scosijnilvo pushed a commit to scosijnilvo/yolov8 that referenced this pull request Jan 19, 2024
hmurari pushed a commit to hmurari/ultralytics that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants