New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved float workspace
arg for TRT exports
#9407
Conversation
CLA Assistant Lite bot All Contributors have signed the CLA. β |
I have read the CLA Document and I sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π Hello @zldrobit, thank you for submitting an Ultralytics YOLOv8 π PR! To allow your work to be integrated as seamlessly as possible, we advise you to:
- β
Verify your PR is up-to-date with
ultralytics/ultralytics
main
branch. If your PR is behind you can update your code by clicking the 'Update branch' button or by runninggit pull
andgit merge main
locally. - β Verify all YOLOv8 Continuous Integration (CI) checks are passing.
- β Update YOLOv8 Docs for any new or updated features.
- β Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." β Bruce Lee
See our Contributing Guide for details and let us know if you have any questions!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9407 +/- ##
=======================================
Coverage 76.94% 76.94%
=======================================
Files 117 117
Lines 14850 14850
=======================================
+ Hits 11426 11427 +1
+ Misses 3424 3423 -1
Flags with carried forward coverage won't be shown. Click here to find out more. β View full report in Codecov by Sentry. |
@zldrobit good change! |
workspace
arg for TRT exports
Co-authored-by: Glenn Jocher <glenn.jocher@ultralytics.com>
I would like to export a TensorRT model with about 250-500MB workspace size, yet the original repo does not allow setting workspace of fractional/float type:
ultralytics/ultralytics/engine/exporter.py
Lines 676 to 679 in 4a7ccba
So, I tweaked the code to accept a float-type workspace. I guess using a lesser workspace (<1GB) is helpful for resource-constrained devices, such as Nvidia Jetson.
π οΈ PR Summary
Made with β€οΈ by Ultralytics Actions
π Summary
Improved configuration and memory handling in Ultralytics software components.
π Key Changes
"workspace"
toCFG_FLOAT_KEYS
for better configuration management."workspace"
from a list where it no longer belongs, streamlining configuration clarity.π― Purpose & Impact