New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix increment +=2
bug in object_counter.py
#9998
Conversation
In case of count by "line points" its adding 2 in counter by each passing object instead of adding 1 in value. Updated to resolve the issue. Issue raised on docs page as well. Video Reference for false output:- https://bit.ly/obj_count_wrong
CLA Assistant Lite bot All Contributors have signed the CLA. β |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π Hello @mianusman618, thank you for submitting an Ultralytics YOLOv8 π PR! To allow your work to be integrated as seamlessly as possible, we advise you to:
- β
Verify your PR is up-to-date with
ultralytics/ultralytics
main
branch. If your PR is behind you can update your code by clicking the 'Update branch' button or by runninggit pull
andgit merge main
locally. - β Verify all YOLOv8 Continuous Integration (CI) checks are passing.
- β Update YOLOv8 Docs for any new or updated features.
- β Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." β Bruce Lee
See our Contributing Guide for details and let us know if you have any questions!
I have read the CLA Document and I sign the CLA |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9998 +/- ##
==========================================
- Coverage 78.99% 73.76% -5.23%
==========================================
Files 121 121
Lines 15332 15332
==========================================
- Hits 12111 11310 -801
- Misses 3221 4022 +801
Flags with carried forward coverage won't be shown. Click here to find out more. β View full report in Codecov by Sentry. |
I have read the CLA Document and I sign the CLA |
@RizwanMunawar is this PR good to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for acknowledging the bug fix!! Contributing to such a valuable resource is truly satisfactory. |
Thank you so much for your kind words and contribution! π It's wonderful to have such supportive and engaged community members. Your efforts help us all move forward together. Keep up the great work! π |
+=2
bug in object_counter.py
@mianusman618 PR merged, thank you for this fix and please let us know if you spot any other problems :) |
Co-authored-by: Glenn Jocher <glenn.jocher@ultralytics.com>
In case of count by "line points" its adding 2 in counter by each passing object instead of adding 1 in value. Updated to resolve the issue. Issue raised on docs page as well. Video Reference for false output:- https://bit.ly/obj_count_wrong
π οΈ PR Summary
Made with β€οΈ by Ultralytics Actions
π Summary
Enhanced accuracy in object counting within counting regions.
π Key Changes
in
count in the class-wise count from 2 to 1 for object tracking.π― Purpose & Impact