Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert(...) changed to save target file alongside the original file #1167

Merged
merged 1 commit into from
May 13, 2020

Conversation

IlyaOvodov
Copy link
Contributor

@IlyaOvodov IlyaOvodov commented May 13, 2020

Current behaviour when convert(...) function saves converted file always as 'converted.pt'/'converted.weights' in a root directory seems to be not intuitive and convenient.
I propose to save converted file side by side with the original one, but with new extension.

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

This PR improves the file naming for model conversion in the yolov3 repository.

📊 Key Changes

  • Changed the output file naming convention when converting models.
  • Instead of generic 'converted' filenames, the output files retain their original base names and only their extensions change to reflect the new format (.pt for PyTorch and .weights for Darknet).

🎯 Purpose & Impact

  • Clarity: The new naming prevents confusion by clearly linking the output files to their original input files.
  • Efficiency: Users can easily identify converted models, streamlining the workflow when working with multiple models.
  • No more ambiguity: The change eliminates potential issues with multiple conversions leading to files with identical names, reducing the risk of overwriting important files.

@glenn-jocher
Copy link
Member

Sounds good. Thanks for updating the README!

@glenn-jocher glenn-jocher merged commit b2fcfc5 into ultralytics:master May 13, 2020
@IlyaOvodov IlyaOvodov deleted the fix_convert_dest branch May 13, 2020 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants