Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .autoshape() method #5694

Merged
merged 1 commit into from
Nov 20, 2021
Merged

Remove .autoshape() method #5694

merged 1 commit into from
Nov 20, 2021

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Nov 17, 2021

Wrap manually instead for more future flexibility.

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Refactoring the AutoShape functionality in Ultralytics YOLOv5 for simpler and streamlined integration.

πŸ“Š Key Changes

  • 🧩 Imported and directly utilized the AutoShape class in hubconf.py when auto-shaping the model.
  • βœ‚οΈ Removed the redundant autoshape() method from both AutoShape and the Model class in yolo.py.
  • πŸ”„ Added logging and attribute copying when initializing AutoShape in common.py.
  • πŸ› οΈ Code cleanliness and maintenance enhancements by consolidating attribute copying logic in the AutoShape class initialization.

🎯 Purpose & Impact

  • πŸš€ The purpose of these changes is to clean up the codebase by removing unnecessary methods, reducing redundancy, and improving the maintainability of the code.
  • πŸ›οΈ Users can expect more straightforward and less-error-prone functionality when auto-shaping models, resulting in an easier integration process.
  • πŸ‘ This change is mostly internal and focused on improving code quality, but it also provides clearer logging during model auto-shaping which might be helpful for users during debugging and model setup.

@glenn-jocher glenn-jocher self-assigned this Nov 17, 2021
@glenn-jocher
Copy link
Member Author

/rebase

@glenn-jocher glenn-jocher merged commit 46daa7b into master Nov 20, 2021
@glenn-jocher glenn-jocher deleted the update/autoshape branch November 20, 2021 00:11
zhiqwang added a commit to zhiqwang/yolort that referenced this pull request Nov 24, 2021
zhiqwang added a commit to zhiqwang/yolort that referenced this pull request Nov 24, 2021
zhiqwang added a commit to zhiqwang/yolort that referenced this pull request Nov 24, 2021
zhiqwang added a commit to zhiqwang/yolort that referenced this pull request Nov 24, 2021
* Update models to yolov5n6 in notebooks

* Update with upstream yolov5

* Following ultralytics/yolov5#5694

* Update models to yolov5n6 in notebooks

* Skip test_load_from_ultralytics_voc for inconsistency
ShiquanYu pushed a commit to ShiquanYu/yolov5-rt-stack that referenced this pull request Dec 27, 2021
* Update models to yolov5n6 in notebooks

* Update with upstream yolov5

* Following ultralytics/yolov5#5694

* Update models to yolov5n6 in notebooks

* Skip test_load_from_ultralytics_voc for inconsistency
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant