Add tracing to validation code for debugging / performance evaluation #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckoopmann
force-pushed
the
ckoopmann/improve-logging
branch
from
3a77a09
to
d05c41d
Compare
alextes
approved these changes
Nov 29, 2023
ckoopmann
force-pushed
the
ckoopmann/improve-logging
branch
from
f632700
to
2749227
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly this PR is meant to add log emission to the Validation api for the purpose of debugging and performance analysis.
In addition I:
ValidationRequestExcutionPayloadthat was sent with the request instead of the parsed log. (since the block hash is verified to be consistent, those values should always be the same)result_option_inspectrust feature which is about to be stabilized in upcoming version version 1.76 (see stabilization pr). Once the stable toolchain is on 1.76 we can switch back to that.closes #9