Ignore "*get_pc_thunk.*" symbols in exported symbols test #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On i386 (32-bit x86) and sparc, gcc generates references to these functions which load the current PC into the specified register. These references are then resolved at link-time. Examples of what these symbols look like: ../src/.libs/libkvazaar.a:libkvazaar_la-cfg.o:00000000 T __x86.get_pc_thunk.ax ../src/.libs/libkvazaar.a:libkvazaar_la-cabac.o:0000000000000000 W __sparc_get_pc_thunk.l7 Since these are platform symbols inserted by the toolchain, ignore them. The regex is specified as tightly as possible, and based on a quick search these appear to be the only two platforms affected.
|
Thanks! |
matoro
added a commit
to matoro/gentoo
that referenced
this pull request
Mar 1, 2024
Includes two new backports for remaining missing arches (x86 + sparc). See: ultravideo/kvazaar#392 See: ultravideo/kvazaar#391 Bug: https://bugs.gentoo.org/902217 Signed-off-by: Matoro Mahri <matoro_gentoo@matoro.tk>
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Mar 8, 2024
Includes two new backports for remaining missing arches (x86 + sparc). See: ultravideo/kvazaar#392 See: ultravideo/kvazaar#391 Bug: https://bugs.gentoo.org/902217 Signed-off-by: Matoro Mahri <matoro_gentoo@matoro.tk> Closes: #35584 Signed-off-by: Sam James <sam@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On i386 (32-bit x86) and sparc, gcc generates references to these functions which load the current PC into the specified register. These references are then resolved at link-time. Examples of what these symbols look like:
Since these are platform symbols inserted by the toolchain, ignore them. The regex is specified as tightly as possible, and based on a quick search these appear to be the only two platforms affected.