Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pkgconfig install #10

Merged
merged 4 commits into from
Sep 23, 2021
Merged

Pkgconfig install #10

merged 4 commits into from
Sep 23, 2021

Conversation

jheo4
Copy link
Contributor

@jheo4 jheo4 commented Mar 30, 2021

This PR is related to the issue #9

  • Add CMake config file to generate .pc file for pkg-config
  • Modify CMakeLists.txt with the config file.

After installing the uvgRTP with pkg-config, uvgRTP can be smoothly used by other projects within their build systems with pkg-config. For the uvgRTP itself, the compile can be done via the below command.

g++ main.cc `pkg-config --libs --cflags uvgrtp`

@altonen
Copy link
Collaborator

altonen commented Mar 31, 2021

Hi @jheo4

I quickly tested this and at least on my machine, pkg_search_module(CRYPTOPP libcrypto++) did not find Crypto++. Changing it to pkg_search_module(CRYPTOPP libcryptopp) did find the library but then there seems to be an issue with the linker:

examples >> g++ configuration.cc `pkg-config --libs --cflags uvgrtp`
/usr/bin/ld: error: /usr/local/include: read: Is a directory
collect2: error: ld returned 1 exit status
examples >> pkg-config --libs --cflags uvgrtp
-I/usr/local/include /usr/local/include -L/usr/local/lib -luvgrtp -lpthread -L/usr/local/lib\;-lcryptopp

Am I using pkg-config incorrectly or what could be the issue here?
Unfortunately right now I cannot dedicate more time for this so I'll get back to you next week.

@jrsnen
Copy link
Member

jrsnen commented Aug 31, 2021

Hi @jheo4! What is the status of this PR? We recently had a big update to our CMake system. Do these changes satisfy you, or do you still have interest to work on this PR?

@jrsnen jrsnen closed this Sep 16, 2021
@jrsnen jrsnen reopened this Sep 22, 2021
@jrsnen jrsnen added this to the Release 2.1 milestone Sep 22, 2021
@jrsnen
Copy link
Member

jrsnen commented Sep 22, 2021

We have decided to try to get pkg-config working for the next release, since the release is mostly focused on the build system. I will see if this PR could be used.

@jrsnen jrsnen self-requested a review September 22, 2021 09:24
@jrsnen jrsnen added the feature New feature label Sep 22, 2021
@jrsnen jrsnen linked an issue Sep 22, 2021 that may be closed by this pull request
# Check PKG_CONFIG_PATH, if not defined, use /usr/local/lib/pkgconfig
if(NOT DEFINED ENV{PKG_CONFIG_PATH})
set( PKG_CONFIG_PATH "/usr/local/lib/pkgconfig")
message("PKG_CONFIG_PATH is not found. Set it with ${PKG_CONFIG_PATH}")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PKG_CONFIG_PATH is not set. Setting it to ${PKG_CONFIG_PATH}.

I think this gives a better impression of what is happening.

@jrsnen
Copy link
Member

jrsnen commented Sep 23, 2021

For me, this branch just works. I will try to merge it and fix issues afterwards.

@jrsnen jrsnen merged commit 4c47961 into ultravideo:master Sep 23, 2021
@jheo4
Copy link
Contributor Author

jheo4 commented Sep 23, 2021

@jrsnen Hi Joni. Sorry for the quiet. It has been quite blasting for me. I checked your comments (thanks for that!) and tested the latest commit of uvgRTP on the clean-slate containers of Ubuntu 18.04 and 20.04. Then, I faced an issue and also resolved it.
I just described the details in Issue #77. Could you check that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uvgRTP installation on Xnix for package-config
3 participants