build: Support for CentOS7 #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 2.0.0 release of uvgRTP fails to build on CentOS7, because : - the gcc-c++ compiler doesn't support the c++17 standard, which is required to compile the crypto.hh file - the getrandom() function isn't available in the libc This pull request adds CentOS7 build support. The modified files are : - CMakeLists.txt : the availability of the getrandom() function is checked. If it exists, the HAVE_GETRANDOM preprocessor definition is added - src/random.cc : if HAVE_GETRANDOM isn't defined, a syscall equivalent to the getrandom() functions is called - include/crypto.hh : the c++17 code is replaced by a code that compiles with the CentOS7 compiler (c++11)
|
The commit looks very good now! Thank you. I'll try to test it this week when I have time. |
|
Thank! I merged this pull request. I'll update the documentation and fix one small issue related to msvc, but otherwise this was very good. Hopefully this helps those with older compilers use uvgRTP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 2.0.0 release of uvgRTP fails to build on CentOS7, because :
required to compile the crypto.hh file
This pull request adds CentOS7 build support.
The modified files are :
CMakeLists.txt : the availability of the getrandom() function is checked.
If it exists, the HAVE_GETRANDOM preprocessor definition is added
src/random.cc : if HAVE_GETRANDOM isn't defined, a syscall equivalent to
the getrandom() functions is called
include/crypto.hh : the c++17 code is replaced by a code that compiles with
the CentOS7 compiler (c++11)