config: allow for custom SSRC. Added thread safety #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I corrected the error that the circleci is giving, but it's not updating |
|
Hi, I tested and this does not compile on Linux due to warnings, if you could fix those, otherwise this looks acceptable. BR, Joni |
wowaser
force-pushed
the
refSSRC
branch
3 times, most recently
from
65d4445
to
db19b52
Compare
|
I think now it is good |
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative solution for #180. Here, we share an SSRC between the objects in a thread-safe way. No intrusion on the API, as opposed to #182.