Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NOISSUE - Enhanced gRPC server concurrency with errgroup #81

Merged
merged 2 commits into from
Feb 8, 2024
Merged

NOISSUE - Enhanced gRPC server concurrency with errgroup #81

merged 2 commits into from
Feb 8, 2024

Commits on Feb 7, 2024

  1. Enhanced gRPC server concurrency with errgroup 

    Refactored the gRPC server's `Process` method to handle incoming messages and service execution concurrently using an `errgroup.Group`. Added a context to the `grpcServer` struct and propagated it to support graceful shutdowns and better request handling. Changed the `Service` interface's `Run` method to use a channel for transmitting `ComputationRunReq`, facilitating non-blocking operation and streamlining the request-response cycle.

Asynchronous handling of stream requests with `errgroup` allows simultaneous processing and error management, improving the server's responsiveness and fault tolerance. This update paves the way for more robust service implementations that require concurrent operations.

Signed-off-by: SammyOina <sammyoina@gmail.com>
    @SammyOina
    SammyOina committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    380b2bf View commit details
    Browse the repository at this point in the history

  2. remove trailing space 

    Signed-off-by: SammyOina <sammyoina@gmail.com>
    @SammyOina
    SammyOina committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    e613403 View commit details
    Browse the repository at this point in the history