Cocos-91 - Update Makefile and cocos documentation #93
Conversation
|
No need for automated installation for now. We can keep CLI in the build dir. This cli will be published on our GitHub on our GitHub, compiled statically and downloadable from GitHub - so no installation will be done via Makefile. |
|
Just remove instructions for installation of the CLI, and use it directly from |
Makefile
Outdated
| @@ -1,12 +1,12 @@ | |||
| BUILD_DIR = build | |||
| INSTALL_DIR = /usr/bin | |||
There was a problem hiding this comment.
Please remove INSTALL_DIR and do not resolve comments and remarks yourself.
Signed-off-by: Jilks Smith <smithjilks@gmail.com>
Signed-off-by: Jilks Smith <smithjilks@gmail.com>
Signed-off-by: Jilks Smith <smithjilks@gmail.com>
Signed-off-by: Jilks Smith <smithjilks@gmail.com>
Signed-off-by: Jilks Smith <smithjilks@gmail.com>
Signed-off-by: Jilks Smith <smithjilks@gmail.com>
Signed-off-by: Jilks Smith <smithjilks@gmail.com>
Signed-off-by: Jilks Smith <smithjilks@gmail.com>
Signed-off-by: Jilks Smith <smithjilks@gmail.com>
Signed-off-by: Jilks Smith <smithjilks@gmail.com>
Makefile
Outdated
| @@ -1,12 +1,12 @@ | |||
| BUILD_DIR = build | |||
| INSTALL_DIR = /usr/bin | |||
There was a problem hiding this comment.
Please remove INSTALL_DIR and do not resolve comments and remarks yourself.
cli/README.md
Outdated
| @@ -7,7 +7,7 @@ This repository contains the command-line interface (CLI) tool for interacting w | |||
| From the project root: | |||
|
|
|||
| ```bash | |||
| make cli | |||
| make | |||
There was a problem hiding this comment.
This is not correct - it should be make cli
There was a problem hiding this comment.
This has been updated
|
|
||
| # compile the manager | ||
| make manager |
There was a problem hiding this comment.
We should be capable to make Manager with make manager
There was a problem hiding this comment.
This has been updated
Signed-off-by: Jilks Smith <smithjilks@gmail.com>
Signed-off-by: Jilks Smith <smithjilks@gmail.com>
manager/README.md
Outdated
|
|
||
| cd $GOPATH/src/github.com/ultravioletrs/cocos | ||
| cd cocos | ||
|
|
||
| # compile the manager |
There was a problem hiding this comment.
Capitalize comments (Compile the Manager)
manager/README.md
Outdated
| @@ -142,16 +142,13 @@ To start the service, execute the following shell script (note a server needs to | |||
|
|
|||
| ```bash | |||
| # download the latest version of the service | |||
There was a problem hiding this comment.
Capitalize the comment (Download the latest version of the service)
Signed-off-by: Jilks Smith <smithjilks@gmail.com>
Updated Makefile to include install instructions for manager.
Updated manager/README.md and cli/README.md to reflect changes in the Makefile.
Resolves #91