This repository has been archived by the owner on Apr 5, 2019. It is now read-only.
minor fix for MS SQL server (group by alias) #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lumn names, not aliases this fixes an issue with ms sql server, which does not seem to be able to apply a group by statement on a column alias not working: SELECT actual_col AS col_alias FROM x GROUP BY col_alias working: SELECT actual_col AS col_alias FROM x GROUP BY actual_col
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a small issue with MS SQL server. It seems as if grouping by a column alias is not supported by SQL server.
I did not test this fix with any other DBMS than MS SQL server. I don't see a reason why it should break compatibility with other DBMS, though, as operations on the actual column names should always work.