Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reactSnippets.settings.importReactOnTop not working #244

Open
DavidArmendariz opened this issue Feb 27, 2022 · 14 comments
Open

reactSnippets.settings.importReactOnTop not working #244

DavidArmendariz opened this issue Feb 27, 2022 · 14 comments
Labels

Comments

@DavidArmendariz
Copy link

This configuration is not working. When I set this in my settings.json:

reactSnippets.settings.importReactOnTop

And then try to use any snippet, it is still importing React on the top.

@chillios-dev
Copy link

@DavidArmendariz please provide full settings.json related to reactSnippets and some repro as on my end works fine.

@DavidArmendariz
Copy link
Author

@dsznajder I don't have any other configurations related to reactSnippets. I only have this in my settings.json:

"reactSnippets.settings.importReactOnTop": false,

The repro would be to type some command like rafce. It would give me something like this:

import React from 'react'

const index = () => {
  return (
    <div>index</div>
  )
}

export default index

@chillios-dev
Copy link

Did you reload vscode after changing this settings as extension said?

@DavidArmendariz
Copy link
Author

@dsznajder Yes!

@saulloalmeida
Copy link

i'm having the same issue with reactSnippets.settings.importReactOnTop setting. Even setting it to false it still keeps showing up with the rfce snippet.

@opes
Copy link

opes commented Apr 6, 2022

I had this same issue recently start happening. I resolved it by toggling the setting on & off again, then invoking Developer: Reload Window.

@notkiran
Copy link

same issue, my setting snd settings.json has -
"reactSnippets.settings.importReactOnTop": false,
but still rafce is importing the react at top. please fix it.
have restarted and reloaded the VS CODE

@dougbeckwith
Copy link

dougbeckwith commented Apr 15, 2022

I'm also having the same issue with ImportReactOnTop setting not working

settings.json is set to this
"reactSnippets.settings.importReactOnTop": false,

When i use the rafce snippet it generates

import React from 'react'

const App = () => {
  return (
    <div>App</div>
  )
}

export default App

please fix thanks :)

@bradenmitchell
Copy link

I am also experiencing this issue. I have done the following steps and it still places the import statement at the top:

  1. Set "reactSnippets.settings.importReactOnTop": true
  2. Reloaded window
  3. Ran rfc confirm import statement is present
  4. Set "reactSnippets.settings.importReactOnTop": false
  5. Reloaded window
  6. Ran rfc confirm import statement is still present (should not be present)

@Jolsty
Copy link

Jolsty commented Nov 14, 2022

I am also having this issue. I am running the latest version (4.4.3) with the setting on false and it still imports React when i use the snippets

@csfx-py
Copy link

csfx-py commented Nov 20, 2022

have the same issue, any updates on this?

@push-on
Copy link

push-on commented Dec 28, 2022

disabling and enabling it fixed for me.
but this solution is not permanent

@Jolsty
Copy link

Jolsty commented Dec 30, 2022

I found that disabling this experimental setting made it work properly again!

image

This was referenced Mar 23, 2023
@hymced
Copy link

hymced commented Nov 28, 2023

As of today, this is still an issue, it feels like the reactSnippets.settings.importReactOnTop setting can disable it, but not re enable it after. I have tested everything:

  • enable the Prettier experimental setting (disabled by default after install) > reload > disable
  • disable the extension > reload> re enable it

The only thing that worked to add back the React import on top after disabling it, is the following:

  • uninstall the extension > restart (not a simple reload!) > comment out the "reactSnippets.settings.importReactOnTop": false setting in User Settings (JSON) or set it to true > re install it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests