Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Iris and Fiber Frameworks as a middleware examples #9

Merged
merged 13 commits into from
Mar 22, 2023
Merged

Support Iris and Fiber Frameworks as a middleware examples #9

merged 13 commits into from
Mar 22, 2023

Conversation

1saifj
Copy link
Contributor

@1saifj 1saifj commented Mar 4, 2023 •
edited
Loading

This is a PR to support both Iris and Fiber frameworks!
Thanks.

@1saifj 1saifj changed the title Support Iris Framework as middleware example Support Iris and Fiber Frameworks as a middleware examples Mar 4, 2023
@1saifj
Copy link
Contributor Author

1saifj commented Mar 18, 2023

@thoas @gillesfabio @kyojin could you please confirm?

novln
novln requested changes Mar 20, 2023
View reviewed changes
Copy link
Collaborator

@novln novln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ensure that your contribution is compiling. Even if they are just examples, it should be the minimum.

Also, you haven't committed your changes on go.mod and go.sum so go runtime from a fresh install doesn't know how to fetch iris for example.

.idea/.gitignore Outdated Show resolved Hide resolved
echo/main.go Outdated Show resolved Hide resolved
fiber/main.go Show resolved Hide resolved
fiber/main.go Outdated Show resolved Hide resolved
iris/main.go Show resolved Hide resolved
@1saifj 1saifj requested a review from novln March 20, 2023 19:06
novln
novln reviewed Mar 21, 2023
View reviewed changes
Copy link
Collaborator

@novln novln left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your changes to add fiber and iris framework as example are working now.
Thank you 👍

However, before I could merge it. Could you fix the two remaining issues:

  • .DS_Store
  • echo framework modification

Cheers,

.DS_Store Outdated Show resolved Hide resolved
echo/main.go Outdated Show resolved Hide resolved
fiber/main.go Show resolved Hide resolved
iris/main.go Show resolved Hide resolved
@1saifj
Copy link
Contributor Author

1saifj commented Mar 21, 2023

Your changes to add fiber and fiber framework as example are working now. Thank you 👍

However, before I could merge it. Could you fix the two remaining issues:

  • .DS_Store
  • echo framework modification

Cheers,

Thanks for the review. updating it now.

@1saifj 1saifj requested a review from novln March 21, 2023 19:39
novln
novln reviewed Mar 22, 2023
View reviewed changes
echo/main.go Outdated Show resolved Hide resolved
@novln
Copy link
Collaborator

novln commented Mar 22, 2023

Perfect 👍

Thank you for your contribution 🙂

@novln novln merged commit b1a155e into ulule:master Mar 22, 2023
@1saifj
Copy link
Contributor Author

1saifj commented Mar 22, 2023

Perfect 👍

Thank you for your contribution 🙂

Thank you too! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@novln novln novln requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@1saifj @novln