Replace GitHub actions using deprecated features (#114)

ulyssa · May 29, 2023 · 32abe1c · 32abe1c
1 parent 0f87036
commit 32abe1c
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 35 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -9,26 +9,8 @@ on:
 name: CI
 
 jobs:
-  clippy_check:
-    runs-on: ubuntu-latest
-    steps:
-    - name: Checkout code
-      uses: actions/checkout@v3
-      with:
-        submodules: true
-    - name: Install Rust
-      uses: actions-rs/toolchain@v1
-      with:
-          toolchain: stable
-          components: clippy
-          override: true
-    - name: Check Clippy
-      uses: actions-rs/clippy-check@v1
-      with:
-        token: ${{ secrets.GITHUB_TOKEN }}
-        toolchain: stable
-        args:
   test:
+    needs: clippy_check
     strategy:
       matrix:
         platform: [ubuntu-latest, windows-latest, macos-latest]
@@ -38,12 +20,12 @@ jobs:
       uses: actions/checkout@v3
       with:
         submodules: true
-    - name: Install Rust
-      uses: actions-rs/toolchain@v1
+    - name: Install Rust (1.66 w/ clippy)
+      uses: dtolnay/rust-toolchain@1.66
       with:
-          toolchain: nightly
-          override: true
-          components: rustfmt, clippy
+          components: clippy
+    - name: Install Rust (nightly w/ rustfmt)
+      run: rustup toolchain install nightly --component rustfmt
     - name: Cache cargo registry
       uses: actions/cache@v3
       with:
@@ -55,19 +37,17 @@ jobs:
         path: target
         key: ${{ runner.os }}-cargo-build-${{ hashFiles('**/Cargo.lock') }}
     - name: Check formatting
-      uses: actions-rs/cargo@v1
+      run: cargo +nightly fmt --all -- --check
+    - name: Check Clippy
+      if: matrix.os == 'ubuntu-latest'
+      uses: giraffate/clippy-action@v1
       with:
-          command: fmt
-          args: --all -- --check
+        github_token: ${{ secrets.GITHUB_TOKEN }}
+        reporter: 'github-check'
     - name: Run tests
-      uses: actions-rs/cargo@v1
-      with:
-          command: test
+      run: cargo test
     - name: Build artifacts
-      uses: actions-rs/cargo@v1
-      with:
-          command: build
-          args: '--release'
+      run: cargo build --release
     - name: Upload artifacts
       uses: actions/upload-artifact@master
       with:

diff --git a/src/windows/room/chat.rs b/src/windows/room/chat.rs
@@ -489,7 +489,7 @@ impl ChatState {
                         .map_err(IambError::from)?;
                 let mime = mime::IMAGE_PNG;
 
-                let name = Cow::from(format!("Clipboard.png"));
+                let name = "Clipboard.png";
                 let config = AttachmentConfig::new();
 
                 let resp = room