Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Nix flake build on Darwin #117

Merged
merged 1 commit into from Jun 23, 2023
Merged

Fix Nix flake build on Darwin #117

merged 1 commit into from Jun 23, 2023

Conversation

satoqz
Copy link
Contributor

@satoqz satoqz commented Jun 7, 2023

Hi there,

building iamb on darwin requires the AppKit and Security frameworks which must be explicitly specified as dependencies when using nix.

Additionally I've removed openssl from the nativeBuildInputs as it's only required in buildInputs and added the result output directory used by nix to the gitignore file.

@benjajaja
Copy link
Contributor

Just tried and linux/x86_64 works as expected, thank you for fixing that nativeBuildInputs!

@ulyssa ulyssa changed the title fix nix build for darwin Fix Nix flake build on Darwin Jun 23, 2023
@ulyssa ulyssa merged commit 758397e into ulyssa:main Jun 23, 2023
3 checks passed
@ulyssa
Copy link
Owner

ulyssa commented Jun 23, 2023

Thank you for fixing the flake build for Darwin, @satoqz , and thank you for checking that it still works on Linux, @benjajaja !

@ulyssa ulyssa mentioned this pull request Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants