Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error message for undefined download directory #87

Merged
merged 1 commit into from Apr 25, 2023

Conversation

mpldr
Copy link
Contributor

@mpldr mpldr commented Apr 25, 2023

The current error message is
thread 'main' panicked at 'no dirs.download value configured!', src/config.rs:327:14
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace

which is not only unelegant, but also wrong. The key iamb expects is dirs.downloads, which is now also reflected in the error message.

@ulyssa
Copy link
Owner

ulyssa commented Apr 25, 2023

Thank you for fixing this! Out of curiosity, what platform are you on, where the dirs::download_dir call is failing to create a path?

@ulyssa ulyssa changed the title fix error message for undefined download directory Fix error message for undefined download directory Apr 25, 2023
@ulyssa ulyssa merged commit b6a318d into ulyssa:main Apr 25, 2023
4 checks passed
@mpldr
Copy link
Contributor Author

mpldr commented Apr 26, 2023

I'm on Linux. Should I run it with backtrace?

@kalloc
Copy link

kalloc commented May 14, 2023

Calling xdg-user-dirs-update would helps

@ulyssa ulyssa mentioned this pull request Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants