Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orthognal vector code may be redundant #67

Closed
dmcconachie opened this issue Feb 6, 2019 · 0 comments
Closed

Orthognal vector code may be redundant #67

dmcconachie opened this issue Feb 6, 2019 · 0 comments

Comments

@dmcconachie
Copy link
Contributor

eigen_helpers.hpp has the following functions:

template <typename DerivedV>
inline Eigen::Matrix<typename DerivedV::Scalar, Eigen::Dynamic, 1> GetArbitraryOrthogonalVector(
            const Eigen::MatrixBase<DerivedV>& vector);

template <typename DerivedV>
inline Eigen::Matrix<typename DerivedV::Scalar, Eigen::Dynamic, 1> GetArbitraryOrthogonalVectorToPlane(
            const Eigen::MatrixBase<DerivedV>& plane_vector1,
            const Eigen::MatrixBase<DerivedV>& plane_vector2,
            const Eigen::MatrixBase<DerivedV>& vector);

Eigen already has some functionality that may do this already, we should check that the functionality is not duplicated.

https://eigen.tuxfamily.org/dox/group__Geometry__Module.html#title53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant