Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two folders named data #8

Closed
rufex2001 opened this issue Apr 5, 2019 · 4 comments
Closed

Two folders named data #8

rufex2001 opened this issue Apr 5, 2019 · 4 comments

Comments

@rufex2001
Copy link
Member

One on the root folder, one inside the kge folder. Perhaps rename the one inside kge to kge/dataset?
@rgemulla
Copy link
Member

rgemulla commented Apr 5, 2019

Right now kge/data only has only dataset.py. I suggest to move dataset.py to kge/, no need for a folder with one file.

@rufex2001
Copy link
Member Author

But all the source code is supposed to be in the kge folder. This would mean there is something to import from outside that kge folder.

@rgemulla
Copy link
Member

rgemulla commented Apr 5, 2019

Why? Move kge/data/dataset.py to kge/dataset.py (where the config.py is).

@rufex2001
Copy link
Member Author

Done. I thought you meant to move it to the other data folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rufex2001 @rgemulla