-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/um 49 query builder api #1573
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
❌ Deploy Preview for heartfelt-souffle-72e1df failed.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few minor things.
components/forms/EventDataForm.js
Outdated
}; | ||
|
||
const handleRemoveTag = (value, list, setState) => { | ||
const { ...rest } = list; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes no sense to spread the list, just use the list.
components/forms/EventDataForm.js
Outdated
setData(data); | ||
|
||
if (message) { | ||
setMessage(null); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to check, just always set it null on success.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow that's awesome
* add uuid to event. add indexes * eventdata api * add event data * remove test data * update list
* add uuid to event. add indexes * eventdata api * add event data * remove test data * update list
query event data