Feat/um 49 query builder api #1573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
❌ Deploy Preview for heartfelt-souffle-72e1df failed.
|
mikecao
approved these changes
Oct 22, 2022
components/forms/EventDataForm.js
Outdated
| }; | ||
|
|
||
| const handleRemoveTag = (value, list, setState) => { | ||
| const { ...rest } = list; |
There was a problem hiding this comment.
Makes no sense to spread the list, just use the list.
components/forms/EventDataForm.js
Outdated
| setData(data); | ||
|
|
||
| if (message) { | ||
| setMessage(null); |
There was a problem hiding this comment.
No need to check, just always set it null on success.
dannyhines
pushed a commit
to dannyhines/umami
that referenced
this pull request
Nov 9, 2022
* add uuid to event. add indexes * eventdata api * add event data * remove test data * update list
benithors
pushed a commit
to benithors/umami
that referenced
this pull request
Nov 10, 2022
* add uuid to event. add indexes * eventdata api * add event data * remove test data * update list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
query event data