add host to visualization #2689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@giuseongit is attempting to deploy a commit to the umami-software Team on Vercel. A member of the Team first needs to authorize it. |
|
In #2710 has emerged the possibility to make this feature configurable, I'd make configurable only the visualization leaving the filtering always enabled. But I'm quite open to any design modifications. |
|
I think the configuration he refers to is only for the interface. the filter via API will continue to exist. |
mikecao
approved these changes
Jun 19, 2024
klawdyo
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2688
Please check the linked issue for possible use cases.
This is the first time i'm working with Next, I've never used it before, so please guide me regarding any aspects I might be missing
EDIT: addresses also #2710