Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[[geo:{lat},{lon}|Directions]] no longer works #1140

Closed
naturistwiki opened this issue Jun 14, 2023 · 6 comments · Fixed by #1141
Closed

[[geo:{lat},{lon}|Directions]] no longer works #1140

naturistwiki opened this issue Jun 14, 2023 · 6 comments · Fixed by #1141
Assignees
Labels

Comments

@naturistwiki
Copy link

naturistwiki commented Jun 14, 2023

Describe the bug
[[geo:{lat},{lon}|Directions]] when used in a Popup content template used to return a link to: <a href="geo:<lat>,<lon>">Directions</a>.
Now only <a>Directions</a> is returned.

To Reproduce
Steps to reproduce the behavior:

  1. Create Popup content template
  2. Add [[geo:{lat},{lon}|Directions]]
  3. View item popup

Expected behavior
Link using html geo schema

Desktop (please complete the following information):

  • OS: Ubuntu
  • Browser: Firefox/Chrome
  • Version: 113.0.2
@yohanboniface
Copy link
Member

Thanks for the report.

@davidbgk may be related to dompurify ?

@davidbgk davidbgk self-assigned this Jun 14, 2023
@davidbgk
Copy link
Contributor

That's my guess too, I'll give it a look 👍

@davidbgk
Copy link
Contributor

davidbgk commented Jun 14, 2023

Indeed: https://github.com/cure53/DOMPurify/blob/main/src/regexp.js#L10

Is geo: a standard link scheme?

I can't see any reference here: https://www.w3.org/wiki/UriSchemes

@davidbgk
Copy link
Contributor

Alright, I found the RFC: https://www.rfc-editor.org/rfc/rfc5870.html

@davidbgk
Copy link
Contributor

Thanks @naturistwiki for reporting!

@naturistwiki
Copy link
Author

Working great! Thanks for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants