Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't edit map (Woops! Someone else seems to have edited the data.) #1212

Closed
CharliePlett opened this issue Jul 18, 2023 · 10 comments · Fixed by #1216
Closed

Can't edit map (Woops! Someone else seems to have edited the data.) #1212

CharliePlett opened this issue Jul 18, 2023 · 10 comments · Fixed by #1216
Labels

Comments

@CharliePlett
Copy link

Describe the bug
When I want to add a line to my map project and hit the save button then I get this error message Woops! Someone else seems to have edited the data. You can save anyway, but this will erase the changes made by others. Even after clicking Ok to saving over other data it just refuses to save it.

To Reproduce
Steps to reproduce the behavior:
It happens only when I edit this map Places I've Been.
I managed to save a few pins the first time that happened, but now I can't even save pins anymore.

Desktop

  • OS: Arch Linux & Windows 11
  • Browser: Firefox
  • Version: 115.0.2 on Arch

Smartphone

  • Device: Xiaomi Redmi Note 10 Pro
  • OS: Android 13
  • Browser: Firefox Nightly
  • Version: 117.0a1

Additional context
I have cleared cookies on the two PC's that I've used this map on already. And also my Smartphone.

@yohanboniface
Copy link
Member

That's annoying, sorry about that :/

Can you open the developer tools of your browser (ctrl-shift-I), then make a change that will reproduce this behavior, and then individuate the URL that cannot be saved (I don't know how comfortable your are with this operation, in case you're not: the URL will be in red in the list).

@yohanboniface
Copy link
Member

OK, I've been able to reproduce the issue thanks to https://forum.openstreetmap.fr/t/modification-dune-carte-umap-aie-quelquun-dautre-semble/16185/6

The issue arise with datalayers created before uMap 1.3.0, in case the geojson file and the geojson.gz was not created on the same second.

If you can tell me which datalayer is impacted (the URL that creates the error), I can fix it by hand. Otherwise let's wait for a proper fix to be released, hopefully soon, today or tomorrow, next week-end at the latest.

@LaurentChm
Copy link

Hello Johan, I have the same issue. I was editing this map https://umap.openstreetmap.fr/en/map/published-studies-on-hot-spot-detection-co2-ch4_809410 this morning. All went fine. But I now suddenly have the same Woops! Someone else seems to have edited the data. You can save anyway, but this will erase the changes made by others. message as above. It seems that there is only one affected layer in the map ("CH4 / General"). Any possible help?

@yohanboniface
Copy link
Member

@LaurentChm can you try again ?

yohanboniface added a commit that referenced this issue Jul 19, 2023
Prior to 1.3.0, uMap was not setting the gzip mtime, so it was
whatever the time it get requested at first.
Since 1.3.0:
- when creating the geojson.gzip, we also force its mtime to be
  the geojson one
- we replaced If-Match by If-Unmodified, which relies on Last-Modified

When uMap is served by a proxy like Nginx (and X-Accel-Redirect),
and if user accepts gzip, then the Last-Modified would be the gzip
one, not the flat geojson one.

So when comparing that value in a subsequent update, we need to
compare with the correct value.

fix #1212
@LaurentChm
Copy link

Still the same :(

@yohanboniface
Copy link
Member

Are you sure about the impacted datalayer ?

@yohanboniface
Copy link
Member

ah, sorry, it may be me mixing "CO2 / General" and "CH4 / General", can you try once again ? :)

@LaurentChm
Copy link

Yes, "CH4 / General"

@LaurentChm
Copy link

It works :) Thanks a lot!

@CharliePlett
Copy link
Author

Thanks for fixing it. It works now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants