Replace "Ctrl" by "Cmd" under macOS and style the "kbd" tag in keyboard shortcuts labels #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 7, 2023
davidbgk
reviewed
Dec 11, 2023
umap/static/umap/js/umap.core.js
Outdated
| shortcut = shortcut.split('+').map((el) => `<kbd>${el}</kbd>`).join('+') | ||
| } | ||
| const modifier = this.isMacOS ? 'Cmd' : 'Ctrl' | ||
| label += ` ${shortcut.replace('Modifier', modifier)}` |
There was a problem hiding this comment.
Suggested change
| label += ` ${shortcut.replace('Modifier', modifier)}` | |
| label += ` (${shortcut.replace('Modifier', modifier)})` |
I think keeping the keyboard shortcut between parenthesis is more readable.
There was a problem hiding this comment.
Once the kbd tag is styled, I find the parenthesis noisy:
vs
What do you think ?
Not intentional, but this box is derived from the buttons, and use the title element, which does not contain the tag of course. I did not put energy on changing that point, because I thought we'd totally change this box to have all the shortcuts, etc. But let's refactor to use something else than the title, you're right. |
This main help already display some of them, so let's first focus on this label refactor, and then do a refactor of that main help modal.
This happens in title attributes, for example.
davidbgk
approved these changes
Dec 15, 2023
yohanboniface
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.