Use bounds instead of center when zooming to Polyline/Polygon #1465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need the map bounds to compute the isOnScreen check
Here is the initial issue: - when using defaultView=latest (means latest element of the default layer) - when map loads, we find the element, call getCenter to center the map on it - but Polygon/Polyline needs the element to be already on the map to call this method (at least because the map CRS is needed) So while trying to fix that issue, I also found that using a centroid for a complex geometry was not very friendly: the map zoom on a part of this geometry, while it seems to be that it's better to have a full view of it. Now that we highlight the selected element, it's also easier to get which element is focused when there are a lot close one to the others.
davidbgk
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the initial issue:
this method (at least because the map CRS is needed)
So while trying to fix that issue, I also found that using a centroid for
a complex geometry was not very friendly: the map zoom on a part of this
geometry, while it seems to be that it's better to have a full view of it.
Now that we highlight the selected element, it's also easier to get which
element is focused when there are a lot close one to the others.