Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a popup template to showcase OpenStreetMap data #1479

Merged
merged 7 commits into from
Jan 8, 2024

Conversation

yohanboniface
Copy link
Member

image

It's a popup template that know how to display data coming from OpenStreetMap. At this stage, it's very basic and only display contact informations, but I'd like to push such a minimalist version and see how users use it before putting more energy on it.

What's not done and may be in further steps:

  • display a i18n label (bakery, swimming pool)
  • automatically display an icon if none is set on the layer
  • show opening hours, or at least show if the shop/amenity is open
  • show more specific tags like the cuisine for a restaurant, the organic tag, etc.
  • connect to panoramax/mapilary to have a picture…

There is no intention to cover all and every possible case, but only to focus on the main tags (shop/amenity…).

Copy link
Contributor

@davidbgk davidbgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get where OSM proprs are actually fetched?

@yohanboniface
Copy link
Member Author

I don't get where OSM proprs are actually fetched?

props are just the normal feature properties. This template is supposed to be used when the features comes from OSM, either by an import or a remote URL (eg. overpass).

umap/static/umap/js/umap.popup.js Outdated Show resolved Hide resolved
umap/static/umap/js/umap.popup.js Outdated Show resolved Hide resolved
umap/static/umap/js/umap.popup.js Outdated Show resolved Hide resolved
@yohanboniface yohanboniface merged commit fe61acd into master Jan 8, 2024
12 checks passed
@yohanboniface yohanboniface deleted the osm-template branch January 8, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants