fix dirty flags when re-ordering layers #1497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The index of the top layer in the view starts with zero, while the rank of the layers count backwards. Thus moving the second-last to the last position should set the dirty flag of rank 0 and 1. Instead the former implementation set the dirty flag for layers >= 19 in a list of 20 layers - resulting in the wrong layers saved. Fixes umap-project#375
|
Sounds good to me. Thanks a lot for spotting this and providing the fix :) |
davidbgk
reviewed
Dec 31, 2023
| if (e.finalIndex === 0) layer.bringToTop() | ||
| else if (e.finalIndex > e.initialIndex) layer.insertBefore(other) | ||
| else layer.insertAfter(other) | ||
| this.map.eachDataLayerReverse((datalayer) => { | ||
| if (datalayer.getRank() >= minIndex) datalayer.isDirty = true | ||
| if (datalayer.getRank() >= minIndex && datalayer.getRank() <= maxIndex) | ||
| datalayer.isDirty = true |
There was a problem hiding this comment.
Why not datalayer.isDirty = datalayer.getRank() >= minIndex && datalayer.getRank() <= maxIndex?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The index of the top layer in the view starts with zero, while the rank of the layers count backwards. Thus moving the second-last to the last position should set the dirty flag of rank 0 and 1. Instead the former implementation set the dirty flag for layers >= 5, when moving "Red" to the bottom in the test map - resulting in the wrong layers saved.
Fixes #375