chore: move ui to dedicated modules #1847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yohanboniface
force-pushed
the
ui-to-modules
branch
from
a6975cf
to
1755535
Compare
yohanboniface
force-pushed
the
ui-to-modules
branch
from
1755535
to
2ed9bc6
Compare
|
There are probably things to go pick from #1641 |
|
Oops, that PR was totally out of my radar :( |
davidbgk
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
umap.ui.jsis removed, and replaced by those two modules:tooltip.jsandalert.jsAlso, panel.js is moved in the same folder
modules/ui/Also, a minimal Dialog class is added, to replace the custom made help box.
Those changes impact a lot of lines, but with very little logic change.
The most notable is certainly that
Requestdoes not expect anymore auiparameter but analertdirectly. And thus, it cannot useuianymore to send its event, so it sends them on the body element, which the Map is then listening.Better to review each commit separately. :)