Allow to star maps and retrieve starred maps #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yohanboniface
changed the title
Binnette
changed the title
davidbgk
reviewed
May 5, 2023
umap/static/umap/img/24-white.png
Outdated
There was a problem hiding this comment.
I'd say we don't need those, because there are no actions nor button in the "edit area" (which is white on black), but I can use those just in case if you think that's more consistent.
umap/static/umap/img/24-white.svg
Outdated
yohanboniface
changed the title
|
See also #1084 |
Co-authored-by: David Larlet <3556+davidbgk@users.noreply.github.com>
Since that initial PR, the username regex has been more gready.
davidbgk
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure we really need this actually, but here is a POC.