Reworked integration of OL5 support. #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenLayers 5 is implemented as a set of ES modules, requiring major changes to the sidebar. Depending on how OL5 is used, the sidebar will either be used as an ES module as well, or, in case the full build of OL (ol.js) is used, a version compiled via webpack for direct usage in a browser environment is required.
|
@severinstrobl Awesome thanks! I hope this would be merged in this neat project! |
|
@umbe1987 Do you want to merge this pull request so we can see if we can get the updated pull request merged into the upstream project? |
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to finally resolve the long awaited integration of OL5 support tracked in Turbo87#143. The dependency on parcel is removed and the OL5 version integrates better with the existing infrastructure.