Expect the correct JSON/RPC results from eth_getFilterChanges calls #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
11 tasks
ferranbt
approved these changes
Jul 22, 2022
bbenzikry
pushed a commit
to bbenzikry/ethgo
that referenced
this pull request
Nov 25, 2022
…mbracle#209) Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See:
The
ethgocode had a workaround in it, for an issue with the Polygon Edge JSON/RPC responses foreth_getFilterChanges. Specifically that they were returning astringrather than JSON Arrays in theresult.This PR updates
ethgoto expect the standard outputs from these JSON/RPC functions, and hence depends on 0xPolygon/polygon-edge#641 to work with Polygon Edge.